Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #880: add information on property updates to the change recorder #881

Merged
merged 1 commit into from
Feb 12, 2023
Merged

Resolves #880: add information on property updates to the change recorder #881

merged 1 commit into from
Feb 12, 2023

Conversation

jarmoniuk
Copy link
Contributor

Release notes:

  • new version and new namespace for the change recorder
  • change recorder also records property changes

@jarmoniuk
Copy link
Contributor Author

@slawekjaranowski please review

@jarmoniuk
Copy link
Contributor Author

target is 2.15

@jarmoniuk jarmoniuk force-pushed the property-version-changes branch 3 times, most recently from 120d680 to c997bb4 Compare January 4, 2023 17:20
@slawekjaranowski slawekjaranowski linked an issue Jan 4, 2023 that may be closed by this pull request
Enhancement: add information on property updates to the change recorder #880
Closed
@jarmoniuk jarmoniuk force-pushed the property-version-changes branch 3 times, most recently from 8fc252b to 67374d9 Compare January 8, 2023 07:29
slawekjaranowski
slawekjaranowski reviewed Jan 25, 2023
View reviewed changes
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need update example in https://www.mojohaus.org/versions/versions-api/change-recorder.html

versions-api/src/main/java/org/codehaus/mojo/versions/api/recording/ChangeRecorder.java Outdated Show resolved Hide resolved
...ons-common/src/main/java/org/codehaus/mojo/versions/change/DefaultPropertyVersionChange.java Outdated Show resolved Hide resolved
...s-common/src/main/java/org/codehaus/mojo/versions/recording/DefaultPropertyChangeRecord.java Outdated Show resolved Hide resolved
@slawekjaranowski slawekjaranowski added this to the 2.15.0 milestone Jan 25, 2023
@jarmoniuk
Copy link
Contributor Author

Applied the review comments.

@jarmoniuk
Resolves mojohaus#880: add information on property updates to the cha…
50367b5 
…nge recorder

Release notes:
- new version and new namespace for the change recorder
- change recorder also records property changes
@slawekjaranowski slawekjaranowski merged commit 2c22da0 into mojohaus:master Feb 12, 2023
@LuciferYang LuciferYang mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawekjaranowski slawekjaranowski Awaiting requested review from slawekjaranowski

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

Enhancement: add information on property updates to the change recorder
2 participants
@jarmoniuk @slawekjaranowski