Issue #16, #17 and #20 test cases and fixes #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 10, 2017
|
Sorry folks I have not used GitHub much until now and I did not realise that committing on my fork would add to the existing pull request. I was expecting to lodge a different pull request for issue #20, as it might be more controversial. What would you like me to do? I'd prefer to leave it here in this pull request, but happy to work with you on this. |
rosslamont
changed the title
|
Too much stuff. Rolling back to original - will open in a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves error handling in certain situations. The apache xml-resolver does not check for file existence and so on and often fails silently. This fixes catch some of those errors.