Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

computation in Summarizer.dbs method is wrong #24

Closed
chengdujin opened this issue Nov 13, 2013 · 3 comments
Closed

computation in Summarizer.dbs method is wrong #24

chengdujin opened this issue Nov 13, 2013 · 3 comments

Comments

@chengdujin
Copy link

Original:
(r._1._1 * r._2._2) / Math.pow(r._1._2 - r._2._2, 2)

Which should be:
(r._1._1 * r._2._1) / Math.pow(r._1._2 - r._2._2, 2)
@tkroman
Copy link
Contributor

tkroman commented Nov 13, 2013

I have already noticed it and fixed it in my PR, but @MojoJolo doesn't seem to be able to accept it right now.

@MojoJolo
Copy link
Owner

Didn't manage to check it right now. Sorry about it. @cdshines. I just saw your pull request. Weird because Github never alerts me.

@a7i7
Copy link

a7i7 commented Mar 4, 2016

Can anyone tell me what is dbs and sbs? I want to know the logic behind it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chengdujin @tkroman @MojoJolo @a7i7