Add OpenAPI schema classes #189
Closed
Conversation
jhthorsen
force-pushed the
jhthorsen/schema-classes
branch
5 times, most recently
from
290aa36
to
709bd26
jhthorsen
force-pushed the
jhthorsen/schema-classes
branch
3 times, most recently
from
2359d4c
to
7b7855d
jhthorsen
force-pushed the
jhthorsen/schema-classes
branch
2 times, most recently
from
095610c
to
3522db4
|
What is the purpose of the subclasses OpenAPIv2 and OpenAPIv3? |
They are part of the validation family. JSON::Validator is a generic validator, meaning it's only the schemas that enforces a given version. |
jhthorsen
changed the title
jhthorsen
force-pushed the
jhthorsen/schema-classes
branch
2 times, most recently
from
27af8a1
to
ae6f8ca
jhthorsen
changed the title
jhthorsen
changed the title
jhthorsen
force-pushed the
jhthorsen/schema-classes
branch
3 times, most recently
from
2a8704d
to
5b7dc2b
jhthorsen
changed the title
|
I think this branch is ready for merging now, but I'll keep it open until I'm done with jhthorsen/mojolicious-plugin-openapi#160 |
|
I'm going to close this for now and open a new PR later on. Going to focus on making J::V compatible with the existing M::P::OpenAPI first. |
This was referenced Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Summary
This change aims to make it possible to move logic from JSON::Validator into the different JSON::Validator::Schema subclasses, but at the same time be backward compatible. After merging this PR, I need to update Mojolicious::Plugin::OpenAPI before moving the actual validation methods. (I think)
Motivation
Same motivation as #209.
References
#209 and #210