New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle text starting w/ a ... #101

Merged
merged 4 commits into from May 31, 2012

Conversation

Projects
None yet
2 participants
@steveburkett
Contributor

steveburkett commented May 25, 2012

hi chronic folks,

how about this? i ran into this issue when i was parsing dates today. hope it helps! :)

@leejarvis

This comment has been minimized.

Collaborator

leejarvis commented May 25, 2012

This looks good. Although it'll only handle a lowercase a, we should probably support both lower and uppercase. Thanks!

@steveburkett

This comment has been minimized.

Contributor

steveburkett commented May 25, 2012

hi all, i added the both case option. any idea of when it might become part of the public gem? for our app, i'll use my forked copy for now. thanks, i was happy to help! ;)

@leejarvis

This comment has been minimized.

Collaborator

leejarvis commented May 25, 2012

Thanks for the change, although can I recommend using /^\s?an? /i instead as I think it looks a littler clearer. I can work on releasing this as part as the gem before the end of next week. Thanks again

@leejarvis

This comment has been minimized.

Collaborator

leejarvis commented May 31, 2012

Merging and modifying myself. Thanks for the code

leejarvis pushed a commit that referenced this pull request May 31, 2012

Lee Jarvis
Merge pull request #101 from steveburkett/a_phrase
handle text starting w/ a ...

@leejarvis leejarvis merged commit 2b5917f into mojombo:master May 31, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment