Permalink
Browse files

gitweb: refactor input parameters parse/validation

Since input parameters can be obtained both from CGI parameters and
PATH_INFO, we would like most of the code to be agnostic about the way
parameters were retrieved. We thus collect all the parameters into the
new %input_params hash, delaying validation after the collection is
completed.

Although the kludge removal is minimal at the moment, it makes life much
easier for future expansions such as more extensive PATH_INFO use or
other form of input such as command-line support.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Acked-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
  • Loading branch information...
1 parent 5c283eb commit 1b2d297e41dbd12c56646796c3d3bcf190f0d5d4 @Oblomov Oblomov committed with spearce Oct 10, 2008
Showing with 178 additions and 137 deletions.
  1. +178 −137 gitweb/gitweb.perl
Oops, something went wrong.

0 comments on commit 1b2d297

Please sign in to comment.