Hunks #32

Closed
wants to merge 1 commit into from

2 participants

@pwnall

Hi!

I'd like to use grit for code review, so I needed to parse the Commit diff and get individual hunks. I figure this is generic functionality that can and should go into grit, so I added a patch.

The old tests pass, sans a small difference -- right now, Commit.diff will never return nil; I figured it doesn't make sense that sometimes it would return nil, and sometimes it would return an empty string, so now it'll always return an empty string when it used to return nil.

I hope you'll consider merging my change, and thank you very much for the awesome code!

@pwnall

Rebased against mojombo/master to get the latest commits. All the tests pass.

@pwnall

Rebased against mojombo/master again. Is there any chance you could take a look at this, please?

@pwnall

Rebased against mojombo/master again.

@pwnall

Rebased against mojombo/master again.

@pwnall

Rebased against mojombo/master again.

@pwnall

Rebased against mojombo/master again.

@bkeepers
Collaborator

Grit is no longer maintained. See #183 and check out libgit2/rugged.

@bkeepers bkeepers closed this Feb 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment