Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix warnings on 1.9 #71

Merged
merged 2 commits into from Jun 10, 2011

Conversation

Projects
None yet
2 participants

This commit fixes several warnings for running under 1.9. Ignoring dependencies:

~/code/grit[d4ed1eb...]% ruby -w -Ilib -rgrit -e ''                          
/Users/lee/code/grit/lib/grit/git-ruby/repository.rb:531: warning: mismatched indentations at 'end' with 'def' at 477
/Users/lee/code/grit/lib/grit/git-ruby/repository.rb:554: warning: shadowing outer local variable - path
/Users/lee/code/grit/lib/grit/git-ruby/repository.rb:725: warning: shadowing outer local variable - path
/Users/lee/code/grit/lib/grit/git-ruby/repository.rb:749: warning: shadowing outer local variable - path
/Users/lee/code/grit/lib/grit/git-ruby/git_object.rb:344: warning: method redefined; discarding old type
/Users/lee/code/grit/lib/grit/git-ruby/file_index.rb:83: warning: method redefined; discarding old files
/Users/lee/code/grit/lib/grit/commit.rb:285: warning: method redefined; discarding old author_string
/Users/lee/code/grit/lib/grit/lazy.rb:26: warning: previous definition of author_string was here
/Users/lee/code/grit/lib/grit/repo.rb:439: warning: shadowing outer local variable - ref

Now:

~/code/grit[master]% ruby -w -Ilib -rgrit -e ''
~/code/grit[master]%

@rtomayko rtomayko commented on an outdated diff Jun 9, 2011

lib/grit/commit.rb
@@ -13,7 +13,7 @@ module Grit
lazy_reader :committed_date
lazy_reader :message
lazy_reader :short_message
- lazy_reader :author_string
+ # lazy_reader :author_string
@rtomayko

rtomayko Jun 9, 2011

Collaborator

Can you remove this entirely?

Collaborator

rtomayko commented Jun 9, 2011

Looks great. Will merge. Thanks!

@rtomayko rtomayko added a commit that referenced this pull request Jun 10, 2011

@rtomayko rtomayko Merge pull request #71 from injekt/master
Fix warnings on 1.9
1c03f3e

@rtomayko rtomayko merged commit 1c03f3e into mojombo:master Jun 10, 2011

Collaborator

rtomayko commented Jun 10, 2011

Merged. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment