Fix true and false matching #8

Merged
merged 1 commit into from Aug 11, 2012

Conversation

Projects
None yet
4 participants
Collaborator

pusewicz commented Feb 18, 2012

@tuncer: Can you please review?

Collaborator

pusewicz commented Apr 30, 2012

@tuncer ping

@tuncer double-ping!

Contributor

tuncer commented Jul 6, 2012

If it doesn't break existing templates and fixes the bug, +1.

hukl commented Jul 13, 2012

So how about merging it in and restoring the functionality of this library? This is a super annoying bug. For now I'm using https://github.com/asynchrony/mustache.erl sigh

Contributor

tuncer commented Jul 24, 2012

ping

There is a possibility of this change breaking some templates somewhere (in addition to fixing the example templates in mustache.erl itself) - it is now essentially impossible to make a template that renders the values "true" and "false", which must be the reason behind the original breaking change that started this.

Someone mentioned to me that riak uses mustache for something, and since I've never used riak much less looked at its code, I'm not at all the right person to ask whether this breaks it.

hukl commented Jul 26, 2012

I'd much rather have a working feature for 99.999999% of the case than the other way around. In the meantime we have created our own fork, pulled in the fixes and have a working template lib.

@pusewicz pusewicz added a commit that referenced this pull request Aug 11, 2012

@pusewicz pusewicz Merge pull request #8 from mojombo/fix-booleans
Fix true and false matching
38a0103

@pusewicz pusewicz merged commit 38a0103 into master Aug 11, 2012

Collaborator

pusewicz commented Aug 11, 2012

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment