Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

ACRE suggest 2 changes to master. #84

Closed
wants to merge 2 commits into from

2 participants

@shoe
Owner

ACRE wants to help you improve your code.

Let him know if you want him to ignore this branch, or
if you would like to leave feedback.

@david
Owner

Awesome!

@david
Owner

I cherry picked some commits. (@shoe)

@david
Owner

"ACRE suggest 5 changes to master." -> "ACRE suggests 5 changes to master."?

"Let him know" -> "Let it know" ?

@david david closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 23, 2013
  1. Convert double-quoted strings to single-quoted strings when there is …

    ACRE authored
    …no interpolation.
    
    2 files were modified.
  2. Normalize hash syntax to ruby 1.9

    ACRE authored
This page is out of date. Refresh to see the latest.
View
2  lib/dill/widgets/widget.rb
@@ -367,7 +367,7 @@ def inspect
rescue Capybara::NotSupportedByDriverError
inspection << "<#{root.tag_name}>\n#{to_s}"
rescue Capybara::ElementNotFound, *page.driver.invalid_element_errors
- "#<DETACHED>"
+ '#<DETACHED>'
end
end
View
2  spec/dill/widgets/list_verification_spec.rb
@@ -10,7 +10,7 @@
Then { failure == Failure(Capybara::ElementNotFound) }
end
- context "to verify equality" do
+ context 'to verify equality' do
context 'when the list is empty' do
GivenHTML <<-HTML
<ul id="skills"></ul>
View
10 spec/dill/widgets/widget_checkpoint_spec.rb
@@ -24,13 +24,13 @@
end
end
- context 'with poltergeist', :js => true, :driver => :poltergeist do
+ context 'with poltergeist', js: true, driver: :poltergeist do
context 'when an obsolete node error is raised' do
- When(:result) {
- checkpoint.call {
+ When(:result) do
+ checkpoint.call do
raise Capybara::Poltergeist::ObsoleteNode.new(nil, nil)
- }
- }
+ end
+ end
Then { result == Failure(Capybara::Poltergeist::ObsoleteNode) }
Then { elapsed > wait_time }
Something went wrong with that request. Please try again.