Add CSS structure and header styles #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // $primary-color: #043878; | ||
| // $secondary-color: #2097B8; | ||
| // $torch-primary-color: #043878; | ||
| // $torch-secondary-color: #2097B8; | ||
| // $tertiary-color: #33752C; |
There was a problem hiding this comment.
Shouldn't all these variables be name-spaced, not just the top two?
There was a problem hiding this comment.
Yes @zberkom. I noted this above.
|
Looks good. Just a little name-spacing I think should be added, but other than that it's great! |
|
@ajrob27 a trick to adding weight to font without changing its width is to use text-shadow: |
|
Nice @yulianglukhenko I'll give that a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add CSS structure and header styles.
Notes:
I removed the bold font-weight on the active link. Having the bold font-weight causes the width of the link to change. In turn this could cause the link at the end of the line to drop down to the next row, which would be annoying.
Also, I am not done with changing variable names and base styles. I'll be updating these as I continue.
Desktop:
Mobile:
No extra work was put into mobile, but this is what it looks like.
@danielberkompas @yulianglukhenko