Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make group roles include each other #7619

Merged
merged 6 commits into from Aug 1, 2018

Conversation

tommydeboer
Copy link
Collaborator

@tommydeboer tommydeboer commented Jul 27, 2018

Checklist

  • Functionality works & meets specifications
  • Code reviewed
  • Code unit/integration/system tested
  • User documentation updated
  • (If you have changed REST API interface) view-swagger.ftl updated
  • Test plan template updated
  • Clean commits
  • Added Feature/Fix to release notes

@dennishendriksen
Copy link
Contributor

dennishendriksen commented Aug 1, 2018

User documentation updated

Should we somehow show in the UI that these roles inherit from each other (update the radio button label for example)? Alternatively add it to the user documentation.

Test plan template updated

How about adding a test case that creates a group using the security manager plugin and grants view permission on the mapping service plugin to the groups viewer role?

but from now on any new group that's added won't have these permission by default.

Even though you'll find that the default settings are sufficient most of the time, you have complete control over all the roles and
permissions in the system if you every wish to change something.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: every -> ever

@@ -108,3 +108,37 @@ You can now view the members of the group and see that the "test" member has a M
You can also remove a member from a group. Click on a member ("test" in this example) and click on "Remove from group".

![Remove member from group](../../images/security/remove_member_from_group.png?raw=true, "Remove member from group")

## Roles and inclusion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice piece of documentation!

@dennishendriksen
Copy link
Contributor

@tommydeboer continuous-integration/travis-ci/pr fails + could you fix the typo?

@dennishendriksen dennishendriksen merged commit 5029991 into molgenis:master Aug 1, 2018
@tommydeboer tommydeboer deleted the fix/role-hierarchy branch March 16, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants