Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix default camera in instance mode #119
Attempts to access the lazy-created default
I had to upgrade the p5.js version used by the examples; the ability to register an 'init' method was released in 0.4.24 and we were on 0.4.21. I went ahead and upgraded all the way to 0.5.4. This means we now depend on p5.js >= 0.4.24, but I'm not sure we've previously recorded that dependency anywhere. Opinions on where to put it?
Examples page changes
It seems registering an init method was not working on the examples page because it would load p5.js once on the page, but would eval p5.play with each example - and also because, for some reason, it was clearing all registered methods prior to eval'ing the examples. I verified that removing this does not cause us to register init too many times.
One nice side effect of this is that you can debug p5.play on the examples page now, which was previously difficult since it was being eval'd.
I think the biggest risk is possible state bleed between examples, but if that's possible I haven't seen it happen yet. We seem to create a new p5 instance for every example anyway.
Fix up sprites_with_sheet example
I'm not sure how this was working before - we were using the result of a loadJSON call on another line inside
referenced this pull request
Oct 20, 2016
@molleindustria we are already serving these at molleindustria.github.io/p5.play, such that anyone with write access to the repository should be able to update it by running update-gh-pages.sh. Back in March @toolness suggested a way to have p5play.molleindustria.org point to the version at github.io, using a CNAME DNS record.
It would be a small step now to get that environment to auto-deploy any time
Regarding the warning, I'm not sure I should fix in this PR; p5.play is legitimately replacing the p5.js method