New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PHP syntax highlighting. #218

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
3 participants
@vernondegoede
Member

vernondegoede commented Sep 12, 2018

Fixes #149.

@vernondegoede vernondegoede requested a review from mollierobbert Sep 12, 2018

@mollierobbert

This comment has been minimized.

Contributor

mollierobbert commented Sep 12, 2018

Nice work, looks much better.

@vernondegoede vernondegoede merged commit 594dd7e into master Sep 12, 2018

@vernondegoede vernondegoede deleted the vernon/improve-php-syntax-highlighting branch Sep 12, 2018

@sandervanhooft

This comment has been minimized.

Collaborator

sandervanhooft commented Sep 13, 2018

@vernondegoede I like how it matches the Mollie theme!

But I'm not sure it's the most balanced in terms of readability, the black is heavier than the blue in my eyes. So the strings get more attention than the operands. ( = string contents get more attention than structure).

It can be me though, not the best set of eyes :).

@sandervanhooft

This comment has been minimized.

Collaborator

sandervanhooft commented Sep 13, 2018

Nevertheless, it's a big improvement over this old style 👍 :

screenshot

@mollierobbert

This comment has been minimized.

Contributor

mollierobbert commented Sep 13, 2018

Thanks for the feedback @sandervanhooft, much appreciated. Accessibility is more important to us than design. @vernondegoede can you tweak it further based on this feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment