New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WGAC compliant color for syntax highlighting #256

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
3 participants
@vernondegoede
Member

vernondegoede commented Oct 1, 2018

Fixes #149. Improved based on the feedback in my previous PR.


@sandervanhooft What do you think?

image

@mattijsbliek

This comment has been minimized.

Member

mattijsbliek commented Oct 2, 2018

Why is everything in the PHP code blue?

@sandervanhooft

This comment has been minimized.

Collaborator

sandervanhooft commented Oct 2, 2018

@vernondegoede It's definitely an improvement! 👍 👍

Didn't know about WGAC, nice.

My IDE is using more colors for php (is this what your comment is about @mattijsbliek ?), but I think this color combination strikes a nice balance between readability and the Mollie design colors. The php examples are simple, as in do not contain class or function definitions.

So it seems really good to me. My eyes are happy.

@vernondegoede

This comment has been minimized.

Member

vernondegoede commented Oct 2, 2018

@mattijsbliek Design chose to make all requests (or code examples blue) and responses yellow. However, since the primary colour is not that readable, I checked what the closest WGAC compliant code was and made our syntax highlighting use that one.

Team Design will probably revamp this page in the future and introduce proper syntax highlighting. I believe this is fine until then.

@mattijsbliek

This comment has been minimized.

Member

mattijsbliek commented Oct 2, 2018

I think both are pretty bad to be honest, but yours is better than what’s currently live so ship it 🤷‍♂️

We should add proper syntax highlighting soon though.

@vernondegoede vernondegoede merged commit 6bb24b1 into master Oct 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@vernondegoede vernondegoede deleted the improve-readability-syntax-highlighting branch Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment