New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve examples #96

Merged
merged 5 commits into from Oct 12, 2018

Conversation

Projects
None yet
2 participants
@vernondegoede
Member

vernondegoede commented Oct 11, 2018

Based on the way we structure our examples in the Ruby client.

While I was creating the examples, I noticed that we are missing the sub-resource to list chargebacks for a payment. I created an issue to keep track of this: #95.

The "integration examples" are now moved to a "with-express" sub-folder, which makes more sense in my opinion.

When this PR is approved, I'll update our api-documentation and add the examples over there as well.

@vernondegoede vernondegoede requested a review from dabroek Oct 11, 2018

@vernondegoede vernondegoede referenced this pull request Oct 11, 2018

Closed

Docs issue #94

@vernondegoede vernondegoede requested a review from lvgunst Oct 11, 2018

@vernondegoede

This comment has been minimized.

Member

vernondegoede commented Oct 12, 2018

@lvgunst Added the example 👍

@vernondegoede vernondegoede merged commit 3185f03 into master Oct 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@vernondegoede vernondegoede deleted the improved-examples branch Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment