Removed deprecated Junit flag from the PHPUnit configuration XML #289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement description
Removal of a deprecated Junit flag that's no longer supported in PHPUnit 7 and clogs up the output of the tests when running them from PHPStorm.
What
Whilst I was working on #282 yesterday, I noticed that the tests I ran from PHPStorm would all output the following message:
This clogs up the test output as can be seen below:
Turns out that this option is deprecated as of PHPUnit 7 as described here: sebastianbergmann/phpunit#2779 and is mostly an issue for the folks still running Jenkins with the Junit plugin in a project where one or more tests are skipped.
This project A) runs on Travis-CI instead of Jenkins and B) has no skipped tests so we are good without this.
How to test
Recommendations