New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node takes 100% CPU when large number of streams are requested #47

Closed
tatsuhiro-t opened this Issue Sep 10, 2013 · 5 comments

Comments

Projects
None yet
2 participants
@tatsuhiro-t

tatsuhiro-t commented Sep 10, 2013

This is a bit pathological case, but I tend to throw large number of requests to my implementation. Today I did to node-http2 server.
The setup is:

$ node example/server.js

And I issued following command:

$ nghttp -nv -m600 https://localhost:8080/server.js

which issues 600 requests in one connection at once.

I observed that after all response data were sent, node server got really slow
and 0-length DATA with END_STREAM bit set was sent very slowly.
And node server's CPU usage became 100%. It kept busy state even after
I killed nghttp.

I use the latest git master of node-http2.

@molnarg

This comment has been minimized.

Show comment
Hide comment
@molnarg

molnarg Sep 10, 2013

Owner

I wanted to do some CPU profiling based optimizations anyway, so it's a good time for me to look into it!

Owner

molnarg commented Sep 10, 2013

I wanted to do some CPU profiling based optimizations anyway, so it's a good time for me to look into it!

@molnarg molnarg closed this in 5c97930 Sep 11, 2013

@molnarg

This comment has been minimized.

Show comment
Hide comment
@molnarg

molnarg Sep 11, 2013

Owner

When there was 0 window left, DATA frames where moved from one place to another a lot, but that's solved now. Thanks for reporting!

Owner

molnarg commented Sep 11, 2013

When there was 0 window left, DATA frames where moved from one place to another a lot, but that's solved now. Thanks for reporting!

@molnarg

This comment has been minimized.

Show comment
Hide comment
@molnarg

molnarg Sep 11, 2013

Owner

Although, it's not perfect yet, there's certainly space for more optimizations.

Owner

molnarg commented Sep 11, 2013

Although, it's not perfect yet, there's certainly space for more optimizations.

@molnarg

This comment has been minimized.

Show comment
Hide comment
@molnarg

molnarg Sep 11, 2013

Owner

I've just noticed that there's an other issue as well, see #48.

Owner

molnarg commented Sep 11, 2013

I've just noticed that there's an other issue as well, see #48.

@tatsuhiro-t

This comment has been minimized.

Show comment
Hide comment
@tatsuhiro-t

tatsuhiro-t Sep 11, 2013

Fix confirmed for #47. Thank you. Also I observed #48 issue as well.

tatsuhiro-t commented Sep 11, 2013

Fix confirmed for #47. Thank you. Also I observed #48 issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment