Handle keyboard-invoked activateFromFiles without selectedFiles#43
Draft
Copilot wants to merge 3 commits into
Draft
Handle keyboard-invoked activateFromFiles without selectedFiles#43Copilot wants to merge 3 commits into
activateFromFiles without selectedFiles#43Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix keyboard shortcut for launching protein viewer
Handle keyboard-invoked May 22, 2026
activateFromFiles without selectedFiles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyboard shortcuts can invoke
protein-viewer.activateFromFileswithout the Explorer multi-select payload, causingundefinedto flow into file rendering and crash on.map(...). This change makes command argument handling resilient across invocation paths (context menu vs keybinding).Command input normalization
getFileUrisToOpen(fileUri, selectedFiles, activeEditorUri)to resolve files in a strict fallback order:selectedFiles(Explorer multi-select)fileUriCrash guard at panel boundary
ProteinViewerPanel.renderFromFiles(...)to short-circuit on empty input and surface a user-facing error instead of dereferencingundefined.Type and call-site hardening
Focused regression coverage