Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return codes from namelist reads are not always checked #149

Open
nichannah opened this issue Jun 22, 2016 · 0 comments
Open

Return codes from namelist reads are not always checked #149

nichannah opened this issue Jun 22, 2016 · 0 comments
Labels

Comments

@nichannah
Copy link
Contributor

For example there is code like:

ierr = check_nml_error(io_status,'ocean_vert_kpp_mom4p1_nml')

and

ierr = check_nml_error(io_status,'ocean_vert_kpp_mom4p1_nml')

but no following check that ierr does not indicate an error. This means that a typo within a namelist would result in default parameters being silently used. Model output will be incorrect without the user knowing.

@nichannah nichannah added the bug label Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant