moment.tz(<moment instance with tz>, <same tz>) returns wrong result

[zgmnkv]

http://jsfiddle.net/bmh34p36/1/

[CarmonColvin]

I am experiencing a similar issue that may be related to this one.
The setup is different and only affects certain dates in the distant past or distant future.

http://jsfiddle.net/3nfw07wu/6/

[kashifshamaz21]

@zgmnkv @CarmonColvin The issue here is with the moment constructor itself, not an issue with moment-timezone.
The moment constructor using an array input seems to be having a bug, as shown below:

moment([2014, 9, 1, 0, 0, 0, 0]).format(); //gives "2014-10-01T00:00:00+05:30"
moment.utc([2014, 9, 1, 0, 0, 0, 0]).format(); //gives "2014-10-01T00:00:00+00:00"

Can one of you raise this issue on https://github.com/moment/moment, and close this one as thats the place this needs to be fixed in.

[zgmnkv]

@kashifshamaz21 why do you think it's a bug with moment constructor? For me it seems fine.

[kashifshamaz21]

@zgmnkv Well, as i mentioned in my earlier comment, creating a moment for 2014-09-01 00:00 using the array constructor is giving incorrect results. It returns 2014-10-01 instead of 2014-09-01
For checking this out quickly, navigate to http://momentjs.com/ , open browser console, copy paste following api calls and check the result:

moment.utc([2014, 09, 01, 0, 0, 0, 0]).format();  // doesn't work. Gives incorrect result
moment.utc("2014-09-01 00:00").format();         // works.

[zgmnkv]

@kashifshamaz21 In js months start from 0

[kashifshamaz21]

@zgmnkv uh, my bad. Sorry for all the confusion, didn't read thru the array constructor note which mentions about the zero-indexing. Okay, digging more into this.

[kashifshamaz21]

@timrwood Any idea on what could be going wrong here? Looks like something to do with cloning of moment.
When we pass a moment instance to moment.tz(momentInstance, zone), it clones the moment instance, right? could it be that, while cloning, we don't keep track of this instance's timezone and hence this 1 hour gap here?

[timrwood]

I think the issue is here.

We need to add another case to make sure things that moments that are passed to moment.tz are not treated as an array.

[timrwood]

#169 should solve this issue.