Skip to content
This repository

i18n: format date #29

Closed
rachel-carvalho opened this Issue · 5 comments

2 participants

Rachel Carvalho Tim Wood
Rachel Carvalho

First I just want to say that this is a great lib, gets the job done and has great i18n support.

Anyway, I'm dealing with a website that has to show dates both in english and in portuguese (great to see that pt was already implemented!). It was all good, until I found this place where I need to write a full date in both languages.

I realized I would need 2 different formats: one for english (MMMM D, YYYY - October 20, 2011) and one for portuguese (D \de MMMM \de YYYY - 20 de Outubro de 2011 [and just now I see that I don't know if it's possible to escape the lowercase d, but anyway, focus]).

Is there a way to call moment().format() with no parameters so that it assumes a default formatting for the whole date?

If there isn't, it would be nice to implement it, I could give it a go.

Maybe a new token that contains the whole date and whole time, like moment().format('T'); // 2:17 PM in english and 14:17 in portuguese. Though I have no idea what a good token would be for the whole date...

Tim Wood
Owner

Yeah, I can see how that would be useful.

It should probably work something like this.

moment().format('L') // 07/10/1986
moment().format('LL') // July 10 1986
moment().format('LLL') // July 10 1986 8:30 PM
moment().format('LLLLL') // Saturday, July 10 1986 8:30PM

Then each language would specify a default format for each length.

By the way, escaping characters should work, but if you're writing as JS strings, you'll need to escape the escape character.

moment().format('D \\de MMMM \\de YYYY');
Rachel Carvalho

Okay, when I've got some time, I'll take a shot at it.

Rachel Carvalho rachel-carvalho referenced this issue from a commit in rachel-carvalho/moment
Rachel Carvalho Added long date format support (issue #29) d440e4e
Rachel Carvalho

When you've got some time, please take a look. I updated the tests and the docs.

I added support for all languages, but I'm just learning french, not completely sure if it's correct and italian I just added the same as french, some google search showed me it should be similar. But it would be good to have someone native to review those.

Tim Wood
Owner

Wow, this looks great! You even updated the docs + unit tests!

Please submit a pull request to the dev branch when you get a chance.

I'll send a message to the people who committed the French and Italian language files about the formats.

Thanks for contributing!

Tim Wood timrwood closed this
Tim Wood
Owner

This is in 1.1.0 and has been published in npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.