New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Duration.clone() #4078

Closed
ishitatsuyuki opened this Issue Jul 21, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@ishitatsuyuki

ishitatsuyuki commented Jul 21, 2017

Duration lacks the ability to clone (and even no copy constructor), while the arithmetic methods mutates the object. It should have clone().

ashsearle added a commit to ashsearle/moment that referenced this issue Jul 21, 2017

@maggiepint

This comment has been minimized.

Member

maggiepint commented Jul 25, 2017

closed #4080

@maggiepint maggiepint closed this Jul 25, 2017

ichernev added a commit that referenced this issue Aug 7, 2017

Merge pull request #4080 from ashsearle:fix/4078
[feature] Implement a clone method for durations, fixes #4078

fbonzon added a commit to fbonzon/moment that referenced this issue Oct 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment