[bugfix] More predictable month diffs at end-of-month #4717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
marwahaha
changed the title
|
just rebased it, to make all builds pass :) |
kakasahebKK
reviewed
Apr 8, 2019
|
are there any plans to merge this? Thank you |
|
That would be great, @kakasahebKK @ichernev @marwahaha please let me know if there is anything more I can do to get this merged :) thanks |
|
Merged in 813eb32 |
ichernev
changed the title
ichernev
added a commit
that referenced
this pull request
Apr 29, 2020
[bugfix] More predictable month diffs at end-of-month
|
I mostly took the tests and used different, more understandable logic to achieve the same result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this resolves both #3980 & #3029 covering all end of month diff edge cases
here is codepen for bugs fixed
this is my first ever pull request :) so please let me know if I need to adjust anything, thanks