New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed a failing iso-format parsing test #1183

Merged
merged 1 commit into from Oct 14, 2013

Conversation

Projects
None yet
2 participants
@ichernev
Contributor

ichernev commented Oct 14, 2013

One of the things that is broken on Android is "including a trailing UTC in the
input should work", which is a test added a long time ago, that used the fact
that ISO format matched beginning of string.

So right now this test goes through Date, which is different on regular vs
mobile browser. Also adding UTC at the end doesn't make it parse a UTC date, so
its misleading to say the least.

I think removing the test makes the most sense in this case. The behavior (of
adding UTC at the end is not documented, so shouldn't break legitimate code).

Removed a failing iso-format parsing test
One of the things that is broken on Android is "including a trailing UTC in the
input should work", which is a test added a long time ago, that used the fact
that ISO format matched beginning of string.

So right now this test goes through Date, which is different on regular vs
mobile browser. Also adding UTC at the end doesn't make it parse a UTC date, so
its misleading to say the least.

I think removing the test makes the most sense in this case. The behavior (of
adding UTC at the end is not documented, so shouldn't break legitimate code).

icambron added a commit that referenced this pull request Oct 14, 2013

@icambron icambron merged commit 5b30f66 into moment:develop Oct 14, 2013

1 check was pending

default The Travis CI build is in progress
Details
@icambron

This comment has been minimized.

Member

icambron commented Oct 14, 2013

@ichernev Agree on all points. If you want to tack random stuff on the end of a date string, it had better be handled by the Date constructor. If Android doesn't handle a trailing 'UTC', those are the breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment