New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tagalog support #1197

Merged
merged 3 commits into from Oct 18, 2013

Conversation

Projects
None yet
2 participants
@hagmandan
Contributor

hagmandan commented Oct 16, 2013

Added tagalog support

@icambron

This comment has been minimized.

Member

icambron commented Oct 16, 2013

The addition of Tagalog is great, but why did so many other languages change?

@hagmandan

This comment has been minimized.

Contributor

hagmandan commented Oct 17, 2013

Un-intentionally committed a few other changes ahead of time - let me roll back to that commit.

As a sneak peek, the other language changes were to make the moment.js language libraries comply more with CLDR (http://cldr.unicode.org/)...

@hagmandan

This comment has been minimized.

Contributor

hagmandan commented Oct 17, 2013

The commit has been rolled back and should include just Tagalog language support.

"returns the name of the language" : function (test) {
test.expect(1);
test.equal(require('../../lang/tl-ph'), 'tl-ph', "module should export tl-ph");

This comment has been minimized.

@icambron

icambron Oct 18, 2013

Member

We recently added tests in this form, but then quickly realized they don't work in the browser and modified them. Looks like you made this test between, though. Not your fault at all, obviously, but can you update this to match https://github.com/moment/moment/blob/develop/test/lang/en-gb.js#L354 ?

@icambron

This comment has been minimized.

Member

icambron commented Oct 18, 2013

Looks good, other than that one test. Once you fix that, I'll merge this in.

@hagmandan

This comment has been minimized.

Contributor

hagmandan commented Oct 18, 2013

test file has been updated! everything should be all set! let me know if there's anything else I can work on for this.

As a separate question, what is your take on CLDR standardization with formatting/naming conventions?

@icambron

This comment has been minimized.

Member

icambron commented Oct 18, 2013

Looks good. Thanks!

On the CLDR thing, I haven't had a chance to look at it. Can you post what you have in a separate pull request and we can kick off the discussion?

icambron added a commit that referenced this pull request Oct 18, 2013

@icambron icambron merged commit f947710 into moment:develop Oct 18, 2013

1 check passed

default The Travis CI build passed
Details

@lae lae referenced this pull request Oct 28, 2013

Merged

Update moment.js to 2.4.0 #2052

@theurere theurere referenced this pull request Jul 1, 2014

Merged

Update moment.js to 2.7.0 #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment