New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welsh language support #1215

Merged
merged 4 commits into from Oct 24, 2013

Conversation

Projects
None yet
2 participants
@robgallen
Contributor

robgallen commented Oct 24, 2013

Please can you add the Welsh translations?

@icambron

This comment has been minimized.

Member

icambron commented Oct 24, 2013

Looks good, thanks. One thing: I suspect this should just register itself as cy instead of cy-gb. A user asking for cy-gb would still get it, and it seems like this would be the right default for someone looking for Welsh.

@robgallen

This comment has been minimized.

Contributor

robgallen commented Oct 24, 2013

Good point. Up till now I've always worked with locale's rather than language. Bizarrely I'd rather imagined cy as cyrillic, i.e. Russian, but I think I just made that up!

@icambron

This comment has been minimized.

Member

icambron commented Oct 24, 2013

Yeah, Russian is ru (Cyrillic is the script, not the language; according to Google, Russian is русский in Russian, which in Latin characters would be Russkiy). In general, this is useful for language codes: http://en.wikipedia.org/wiki/List_of_ISO_639-1_codes

Anyway, thanks for the new language!

icambron added a commit that referenced this pull request Oct 24, 2013

@icambron icambron merged commit 6ed3112 into moment:develop Oct 24, 2013

1 check passed

default The Travis CI build passed
Details

@theurere theurere referenced this pull request Jul 1, 2014

Merged

Update moment.js to 2.7.0 #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment