Testing/sauce labs integration #1374

Merged
merged 23 commits into from Dec 29, 2013

Conversation

Projects
None yet
3 participants
Contributor

ichernev commented Dec 25, 2013

This is a continuation of #1301

@alexstrat any comments? I already used this setup to test the latest release, so in terms of usability -- it works (haven't tested the travis build hooks though).

A few tests fail right now (IE8 and Safari), these are being worked on, so ignore them :)

Contributor

ichernev commented Dec 25, 2013

TODO:

  • fix the broken tests, or somehow make the build succeed with broken tests (don't think it is a good idea)
  • the sauce launcher is broken, it thinks it prints to a terminal, and if the terminal is too narrow (or there is no terminal) it prints status of each browser a few times per second, which floods the logs like crazy -- travis is complaining
Contributor

alexstrat commented Dec 27, 2013

Looks good!

Concerning the terminal issue, you should probably change the reporter to something more Travis friendly like the dot reporter.

Member

icambron commented Dec 28, 2013

This is so awesome. Is this ready to merge?

Contributor

ichernev commented Dec 28, 2013

If you're happy I'll merge it. I want to take one last look.
On Dec 27, 2013 6:23 PM, "Isaac Cambron" notifications@github.com wrote:

This is so awesome. Is this ready to merge?


Reply to this email directly or view it on GitHubhttps://github.com/moment/moment/pull/1374#issuecomment-31288406
.

@icambron icambron commented on the diff Dec 28, 2013

moment.js
@@ -1497,11 +1497,7 @@
//http://en.wikipedia.org/wiki/ISO_week_date#Calculating_a_date_given_the_year.2C_week_number_and_weekday
function dayOfYearFromWeeks(year, week, weekday, firstDayOfWeekOfYear, firstDayOfWeek) {
- // The only solid way to create an iso date from year is to use
- // a string format (Date.UTC handles only years > 1900). Don't ask why
- // it doesn't need Z at the end.
- var d = new Date(leftZeroFill(year, 6, true) + '-01-01').getUTCDay(),
- daysToAdd, dayOfYear;
+ var d = makeUTCDate(year, 0, 1).getUTCDay(), daysToAdd, dayOfYear;
@icambron

icambron Dec 28, 2013

Member

what happened here? Seems like a rollback?

@ichernev

ichernev Dec 28, 2013

Contributor

Ie doesn't parse long years at all. When I wrote the original code the
makeDate functions didn't work with small years (or for some unknown stupid
reason) I wrote the string parsing inside... Stupid idea.
On Dec 27, 2013 9:12 PM, "Isaac Cambron" notifications@github.com wrote:

In moment.js:

@@ -1497,11 +1497,7 @@

 //http://en.wikipedia.org/wiki/ISO_week_date#Calculating_a_date_given_the_year.2C_week_number_and_weekday
 function dayOfYearFromWeeks(year, week, weekday, firstDayOfWeekOfYear, firstDayOfWeek) {
  •    // The only solid way to create an iso date from year is to use
    
  •    // a string format (Date.UTC handles only years > 1900). Don't ask why
    
  •    // it doesn't need Z at the end.
    
  •    var d = new Date(leftZeroFill(year, 6, true) + '-01-01').getUTCDay(),
    
  •        daysToAdd, dayOfYear;
    
  •    var d = makeUTCDate(year, 0, 1).getUTCDay(), daysToAdd, dayOfYear;
    

what happened here?


Reply to this email directly or view it on GitHubhttps://github.com/moment/moment/pull/1374/files#r8575464
.

Member

icambron commented Dec 28, 2013

OK, I'm happy with this. Good work!

Contributor

ichernev commented Dec 29, 2013

We have a bug with weekYear/week/weekday setters. Lets fight it in another issue/PR.

@ichernev ichernev added a commit that referenced this pull request Dec 29, 2013

@ichernev ichernev Merge pull request #1374 from ichernev/testing/sauce-labs-integration
Testing/sauce labs integration

@changelog
@section misc
@description Run tests on multiple browser/os combos via SauceLabs and Travis
ef0365e

@ichernev ichernev merged commit ef0365e into moment:develop Dec 29, 2013

1 check failed

default The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment