New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change object construction to prevent Chrome v32 crashing. #1429

Merged
merged 1 commit into from Jan 22, 2014

Conversation

Projects
None yet
2 participants
@tatey
Contributor

tatey commented Jan 20, 2014

We were getting reports that our website was crashing in Chrome. We were able to pinpoint it to moment.

Changing the config from a literal object to setting properties is ugly, but resolves the issue for us in production. Given how frequently Chrome is updated I suspect we'll be able to revert it once it's fixed upstream.

See #1423.

Change object construction to prevent Chrome v32 crashing.
Suspected JS execution optimizations in v32 is causing the browser to
throw "Aw, Snap".

See #1423
@ichernev

This comment has been minimized.

Contributor

ichernev commented Jan 22, 2014

Thank you for troubleshooting and patching this. Can you please submit and link a chrome bug for this?

ichernev added a commit that referenced this pull request Jan 22, 2014

Merge pull request #1429 from thebestday/bugfix/chrome-v32
Change object construction to prevent Chrome v32 crashing.

@changelog
@Section bugfix

@ichernev ichernev merged commit b92af0d into moment:develop Jan 22, 2014

1 check passed

default The Travis CI build passed
Details

@theurere theurere referenced this pull request Jul 1, 2014

Merged

Update moment.js to 2.7.0 #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment