New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly configure component in composer.json #1499

Merged
merged 1 commit into from Mar 5, 2014

Conversation

Projects
None yet
2 participants
@kperry42
Contributor

kperry42 commented Feb 27, 2014

Provides correct "authors" property, and more importantly, adds the needed properties for use with the Composer component-installer.

One note: I've chosen to include only the base moment.js in the default script build, and load the other, larger, files as alternative files that can be loaded if desired. I think this makes the most sense, as there will be more projects that just want to use one or a few languages and don't want to load the entire language pack. I've also included the individual language files, so one can
require(["moment", "moment/lang/fr"], ...);
for instance, to load individual languages.

@icambron

This comment has been minimized.

Member

icambron commented Mar 5, 2014

That makes sense. Thanks!

icambron added a commit that referenced this pull request Mar 5, 2014

Merge pull request #1499 from kperry42/feature/composer
Properly configure component in composer.json

@icambron icambron merged commit 91efba1 into moment:develop Mar 5, 2014

1 check passed

default The Travis CI build passed
Details

@theurere theurere referenced this pull request Jul 1, 2014

Merged

Update moment.js to 2.7.0 #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment