New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure no Date constructor is used in tests #1577

Merged
merged 1 commit into from Apr 2, 2014

Conversation

Projects
None yet
2 participants
@ichernev
Contributor

ichernev commented Apr 2, 2014

This is step one for deprecating the Date constructor. First merge #1564 to get the deprecate function and actually deprecate the newly extracted function so it'd print a warning if moment construction hits Date.

@icambron

This comment has been minimized.

Member

icambron commented Apr 2, 2014

Looks good.

icambron added a commit that referenced this pull request Apr 2, 2014

Merge pull request #1577 from ichernev/extract-date-constructor
Make sure no Date constructor is used in tests

@icambron icambron merged commit ba96963 into moment:develop Apr 2, 2014

1 check passed

default The Travis CI build passed
Details

@theurere theurere referenced this pull request Jul 1, 2014

Merged

Update moment.js to 2.7.0 #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment