New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not export a global in node.js #1589

Merged
merged 1 commit into from Apr 4, 2014

Conversation

Projects
None yet
2 participants
@ichernev
Contributor

ichernev commented Apr 4, 2014

We didn't have that for a few months, nobody complained. In Node.JS environment all software is module-aware, so I really don't see the need for a global. It can be exported at will if that is desired.

icambron added a commit that referenced this pull request Apr 4, 2014

@icambron icambron merged commit 1ca72d1 into moment:develop Apr 4, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@icambron

This comment has been minimized.

Member

icambron commented Apr 4, 2014

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment