New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate pre-2.0 add/subtract #1763

Merged
merged 18 commits into from Jul 14, 2014

Conversation

Projects
None yet
3 participants
@icambron
Member

icambron commented Jul 6, 2014

Fix for #1729:

  • DRY for add/subtract
  • Deprecate old arg ordering
  • Fix internal uses and test uses (except, of course, ones specifically testing add/subtract)
  • Renamed tests so that "reversed" now means the opposite
@icambron

This comment has been minimized.

Member

icambron commented Jul 6, 2014

Looks like I'll need to rebase. I'll do that after I get some feedback.

moment.js Outdated
@@ -487,7 +497,23 @@
return res;
}
// helper function for _.addTime and _.subtractTime
//todo: remove 'name' arg after deprecation is removed

This comment has been minimized.

@ichernev

ichernev Jul 8, 2014

Contributor
// TODO: something
@ichernev

This comment has been minimized.

Contributor

ichernev commented Jul 8, 2014

Pretty good, I would have done the same. Great job with fixing all the internal uses and renaming the tests. Reverse reverse args for the win :)

You can merge after the rebase.

ichernev and others added some commits Jul 8, 2014

Merge pull request #1759 from icambron/iso_vs_ISO
Change duration.toIsoString to duration.toISOString

@changelog
@Section deprecation
@description rename duration.toIsoString to duration.toISOString

icambron added a commit that referenced this pull request Jul 14, 2014

@icambron icambron merged commit 2733206 into moment:develop Jul 14, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment