New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Myanmar localization #1778

Merged
merged 1 commit into from Jul 21, 2014

Conversation

Projects
None yet
6 participants
@gholadr
Contributor

gholadr commented Jul 17, 2014

fixed formatting issues (jscs) as reported by Travis

@yelinaung

This comment has been minimized.

yelinaung commented Jul 17, 2014

LGTM but what happened to README O.o

@yelinaung

This comment has been minimized.

yelinaung commented Jul 17, 2014

Anyway, @thanyawzinmin, @saturngod, @trhura, @setkyar, can you guys take a look at the my.js ?

@gholadr

This comment has been minimized.

Contributor

gholadr commented Jul 17, 2014

:-o
Good catch @yelinaung! - undeleted README.md

@talnetd

This comment has been minimized.

talnetd commented Jul 17, 2014

What kind of Encoding you used there ? Can't read up correctly here !

@icambron

This comment has been minimized.

Member

icambron commented Jul 17, 2014

Do you mind squashing these commits down? Normally we don't mind a few commits in one PR, but that's a lot.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Jul 17, 2014

I guess the original plan was to keep the list of contributors .. but this has gone out of control :)

@setkyar

This comment has been minimized.

setkyar commented Jul 18, 2014

Why is the nextWeek : 'dddd LT [မှာ]', ? It's not နောက်အပတ် ? @yelinaung @htlwin2006

@gholadr

This comment has been minimized.

Contributor

gholadr commented Jul 18, 2014

@icambron - done, we've squashed the commits as requested.

@gholadr

This comment has been minimized.

Contributor

gholadr commented Jul 21, 2014

@icambron - looks like we have consensus on our end and this PR is ready.

icambron added a commit that referenced this pull request Jul 21, 2014

@icambron icambron merged commit ef5f151 into moment:develop Jul 21, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@icambron

This comment has been minimized.

Member

icambron commented Jul 21, 2014

Awesome, thanks everyone!

@gholadr

This comment has been minimized.

Contributor

gholadr commented Jul 21, 2014

sweet! thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment