New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[locale/ar] Use native plural forms #1801

Closed
wants to merge 6 commits into
base: develop
from

Conversation

Projects
None yet
4 participants
@forabi
Contributor

forabi commented Jul 26, 2014

No description provided.

@forabi

This comment has been minimized.

Contributor

forabi commented Jul 26, 2014

Closes #1799

@butterflyhug

This comment has been minimized.

Member

butterflyhug commented Jul 26, 2014

Awesome! Looks like you'll need to update the tests to expect the right plural forms, though.

@Menelion

This comment has been minimized.

Menelion commented Jul 26, 2014

@forabi, yes, please change the tests accordingly.

@forabi

This comment has been minimized.

Contributor

forabi commented Jul 27, 2014

@Oire I updated the tests

@ichernev

This comment has been minimized.

Contributor

ichernev commented Aug 5, 2014

@abdelsaid can you please verify this change

@forabi

This comment has been minimized.

Contributor

forabi commented Aug 5, 2014

Looks like he deleted his account. I understand you need some form of verification, but the old translations are the incorrect ones, they were simply a 1:1 translation of the English strings, many translators do not care enough to use the correct forms because either they do not know how to implement the correct forms or the code does not provide a way to implement them and they need to rewrite core functions to handle this case, which may not be easy.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Aug 5, 2014

This looks good then. Will merge in next patch release.

@ichernev ichernev added this to the 2.8.3 milestone Aug 29, 2014

@ichernev

This comment has been minimized.

Contributor

ichernev commented Sep 5, 2014

Merged in 25df5b3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment