New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added meridiem parsing functions for el language #1812

Closed
wants to merge 2 commits into
base: develop
from

Conversation

Projects
None yet
4 participants
@nikoskalogridis
Contributor

nikoskalogridis commented Jul 31, 2014

No description provided.

@Menelion

This comment has been minimized.

Menelion commented Jul 31, 2014

@nikoskalogridis, please provide tests for this functionality.
@mehiel, what do you think?

@nikoskalogridis

This comment has been minimized.

Contributor

nikoskalogridis commented Jul 31, 2014

@Oire, ok added a few tests :-) let me know if this is ok now

@mehiel

This comment has been minimized.

Contributor

mehiel commented on locale/el.js in 30953cb Aug 1, 2014

is second M optional for a reason?

@mehiel

This comment has been minimized.

Contributor

mehiel commented on test/locale/el.js in f4c65f9 Aug 1, 2014

I'm just not sure if this should be a valid meridiem. I've just never seen that again. If you're sure it should be valid or add a reference it would be great.

@mehiel

This comment has been minimized.

Contributor

mehiel commented Aug 1, 2014

@Oire, other than that it's good to go! Thanks @nikoskalogridis.

@nikoskalogridis

This comment has been minimized.

Contributor

nikoskalogridis commented Aug 1, 2014

@mehiel, it helps my users to save a character on data entry thats why its included. Also in the documentation section AM/PM parsing for the en language the first character is also enough for parsing. But if you feel its too informal I could change that. Let me know what you think :)

@ichernev

This comment has been minimized.

Contributor

ichernev commented Aug 5, 2014

Thank you @nikoskalogridis @mehiel @Oire for the help!

This is ready for merge (next patch release).

@ichernev ichernev added this to the 2.8.2 milestone Aug 5, 2014

ichernev added a commit to ichernev/moment that referenced this pull request Aug 20, 2014

Merge pull request moment#1812 from nikoskalogridis/master
Add meridiem parsing functions for el language

@changelog
@Section lang-bugfix
@ichernev

This comment has been minimized.

Contributor

ichernev commented Aug 20, 2014

Merged in 09d5b2a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment