New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing unit tests asserting old moment().lang(str) behavior #1813

Merged
merged 3 commits into from Aug 1, 2014

Conversation

Projects
None yet
1 participant
@ichernev
Contributor

ichernev commented Jul 31, 2014

It looks like we broke moment().lang(key) in 2.8.0. Take a look at the added (failing) unit tests.

@ichernev ichernev referenced this pull request Aug 1, 2014

Closed

fixing lang deprecation #1819

ichernev added a commit that referenced this pull request Aug 1, 2014

Merge pull request #1813 from ichernev/bugfix/maintain-lang-original-…
…behavior

Fix moment().lang([key]) backwards compatibility broken in 2.8.0.

@ichernev ichernev merged commit 96ee96a into moment:develop Aug 1, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@Martii Martii referenced this pull request Aug 22, 2014

Closed

Deprecation Warnings #315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment