New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moment diff across dst in weird cases #1848

Merged
merged 2 commits into from Sep 5, 2014

Conversation

Projects
None yet
1 participant
@ichernev
Contributor

ichernev commented Aug 10, 2014

moment diff across dst was sometimes failing because of a floating point
rounding. Just make sure to first do additions/subtractions and then division.

fixes #1842

@ichernev ichernev added this to the 2.8.3 milestone Aug 22, 2014

@ichernev ichernev referenced this pull request Aug 29, 2014

Closed

months diff bug #1842

ichernev added some commits Aug 10, 2014

Fix moment diff across dst in weird cases
moment diff across dst was sometimes failing because of a floating point
rounding. Just make sure to first do additions/subtractions and then division.

ichernev added a commit that referenced this pull request Sep 5, 2014

Merge pull request #1848 from ichernev/bugfix/fix-month-diff
Fix moment diff across dst in weird cases

@ichernev ichernev merged commit f6d5c0c into moment:develop Sep 5, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment