New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance optimization isBefore/isAfter/isSame #1892

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
3 participants
@hupfis
Contributor

hupfis commented Aug 29, 2014

  • optimized performance of isBefore/isAfter/isSame by using valueOf and not momentizing/cloning already existing moment objects
  • 90% performance improvement when using without specific unit and the input is already a moment object

reviewed by PatrickBic/tscheinecker

Performance optimization isBefore/isAfter/isSame
- optimized performance of isBefore/isAfter/isSame by using valueOf and not momentizing/cloning already existing moment objects
- 90% performance improvement when using without specific unit and the input is already a moment object

reviewed by PatrickBic/tscheinecker

@ichernev ichernev added this to the 2.8.3 milestone Sep 5, 2014

ichernev added a commit that referenced this pull request Sep 5, 2014

@ichernev

This comment has been minimized.

Contributor

ichernev commented Sep 5, 2014

Merged in 108faa5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment