New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added formatToken 'x' for unix offset in milliseconds #1938 #1960

Closed
wants to merge 3 commits into
base: develop
from

Conversation

Projects
None yet
2 participants
@doedje
Contributor

doedje commented Oct 6, 2014

I added the code for 'x' as a formatToken for both creating and formatting... I added the unittests. Hope it is sufficient like it is now...

I did have a problem with the name unix offset as it might be confusing with a timezone offset, but I am not a native english speaker so I just included in milliseconds everywhere I could. And the function unixms might not be needed, it's probably better to use valueOf(). But I leave that decision making up to you....

@ichernev

This comment has been minimized.

Contributor

ichernev commented Oct 9, 2014

That looks great. We'll merge it in the next release.

@ichernev ichernev modified the milestones: 2.8.3, 2.8.4 Oct 9, 2014

@ichernev ichernev closed this Nov 17, 2014

ichernev added a commit that referenced this pull request Nov 17, 2014

Merge pull request #1960 from doedje:develop
added formatToken 'x' for unix offset in milliseconds #1938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment