New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display localized time with seconds (Improvement requested in #1997) #2000

Closed
wants to merge 3 commits into
base: develop
from

Conversation

Projects
None yet
2 participants
@mattgrande
Contributor

mattgrande commented Oct 21, 2014

A few notes: This has come up several times before (see: #991, #1288)

Thanks to baryon for the Japanese and Chinese translations (see #1802).

Here is how the time 3:25:50 PM would show in all languages/cultures:

The vast majority of languages/cultures use 15:25:50 , with the exception of:

3:25:50 PM -> en-au, en-ca, en, ka
15.25.50 -> fi, id, ms-my, nb
١٥:٢٥:٥٠ -> ar-sa, ar
15:25:50 Uhr -> de-at, de
দুপুর ৩:২৫:৫০ সময় -> bn
ཉིན་གུང ༣:༢༥:༥༠ -> bo
3e25:50 PM -> br
3:25:50 ΜΜ -> el
۱۵:۲۵:۵۰ -> fa
दोपहर ३:२५:५० बजे -> hi
午後3時25分50秒 -> ja
오후 3시 25분 50초 -> ko
15:25:50 Auer -> lb
15:25:50 val. -> lt
ഉച്ച കഴിഞ്ഞ് 3:25:50 -നു -> ml
दुपारी ३:२५:५० वाजता -> mr
၁၅:၂၅:၅၀ -> my
बेलुकाको ३:२५:५० बजे -> ne
15 นาฬิกา 25 นาที 50 วินาที -> th
下午3点25分50秒 -> zh-cn
下午3點25分50秒 -> zh-tw

For Breton (br), CLDR does not recognise 'e' has the hour separator. It indicates that the time should be 15:25, not 15e25; See "Formats - Standard - Time Formats" on that page.

Catalan (ca) and Galician (gl) did not have any of the standard formatting tests; someone familiar with the language should give it a once-over to make sure what was there is correct.

Thai (th) is based off of Google Translate; someone familiar with the language should give it a once-over.

*Please note, this is my first pull request. Feel free to criticise.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Oct 24, 2014

Oh, wow, that's an epic change. I'll merge it in next release.

@ichernev ichernev added this to the 2.8.4 milestone Oct 24, 2014

@mattgrande

This comment has been minimized.

Contributor

mattgrande commented Oct 24, 2014

You guys have lots of locales! Each locale file + a test for each = one huge commit!

@ichernev ichernev closed this Nov 17, 2014

ichernev added a commit that referenced this pull request Nov 17, 2014

Merge pull request #2000 from mattgrande:develop
Display localized time with seconds (Improvement requested in #1997)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment