Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve unit bubbling for ISO dates #2357
What is this?
This PR intends to fix issues with invalid ISO dates getting created from a well formatted
What I have done is basically:
Why is it useful?
The ISO 8601 standard (which I only know from second hand knowledge), makes a difference between hours, days and months. That is:
Thus from an ISO perspective there is a difference between
Note: I've written down similar arguments in the linked issues, but I believe it helps clarity to repeat it if I open a PR ^^
Seems like the current
I rebased my PR onto master, so that travis should report it green. Local results:
referenced this pull request
May 5, 2015
@NobodysNightmare thank you for working on this!
You did the right thing. We store milliseconds and days separately exactly for this reason (days should go over DST as it doesn't exist, and hours, minutes, seconds should advance time exactly)
Sorry for that. Your change looks good. When I merge I make sure all tests pass (on top of the other changes scheduled for the release).
Will merge in next release.