New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two digit year parsing with YYYY format #2494

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
3 participants
@stewartml

stewartml commented Jul 20, 2015

Further to the discussion in #2344, this PR provides an alternative way to fix #2343.

I've had to delete one of the existing tests to get this to pass -- it seems that although a couple of people have agreed that the behaviour described in #2343 is unwanted, there was actually a test there to make sure it happened.

@mj1856

This comment has been minimized.

Member

mj1856 commented Jul 21, 2015

Could you please rebase to squash the extra commits into the first one? Thanks.

Stewart MacKenzie-Leigh
Fix two digit year parsing with YYYY format
Two digit years will use the parseTwoDigitYear function when parsing with the YYYY format.
Closes #2343

@ichernev ichernev added this to the 2.10.5 milestone Jul 26, 2015

@ichernev

This comment has been minimized.

Contributor

ichernev commented Jul 26, 2015

Merged in 768cfcc

@ichernev ichernev closed this Jul 26, 2015

ichernev added a commit that referenced this pull request Jul 26, 2015

Merge pull request #2494 from stewartml:yyyy-fix
Fix two digit year parsing with YYYY format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment