New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handling of invalid moments #2624

Closed
wants to merge 4 commits into
base: develop
from

Conversation

Projects
None yet
1 participant
@ichernev
Contributor

ichernev commented Sep 21, 2015

Implement proper handling of invalid moments across all methods.

The current situation is that only format will display moments as invalid, but most other methods will kind of work with some "undefined behavior" Date object stored underneath.

Now all methods are predictable (I added tests) and work almost like NaNs -- operations involving them result in more NaNs and boolean checks return false.

Fixes #2619

@ichernev ichernev added this to the 2.10.7 milestone Nov 9, 2015

@ichernev

This comment has been minimized.

Contributor

ichernev commented Nov 9, 2015

Merged in d58a049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment