New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strict month parsing issue in cs,ru,sk #2634

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
2 participants
@ichernev
Contributor

ichernev commented Sep 23, 2015

So I added short and long months parse arrays where they were needed and updated the tests

  • fix broken locales
  • make sure we check for that when we create a locale
  • add strict month parsing tests for all locales

fixes #2243, obsoletes #2493, #2527

@ichernev

This comment has been minimized.

Contributor

ichernev commented Nov 9, 2015

Merged in c3c412e

@ichernev ichernev closed this Nov 9, 2015

ichernev added a commit that referenced this pull request Nov 9, 2015

Merge pull request #2634 from ichernev:fix-strict-month-parsing
Fix strict month parsing issue in cs,ru,sk
@iamstarkov

This comment has been minimized.

iamstarkov commented Nov 12, 2015

@ichernev thanks you for fix. will you publish it soon?

@iamstarkov

This comment has been minimized.

iamstarkov commented Nov 17, 2015

any plan for release?

@ichernev

This comment has been minimized.

Contributor

ichernev commented Nov 17, 2015

@iamstarkov I'm working on it right now, no specific date but should happen soon. You can follow this to cut a release from develop (just for you), which should be good enough for you.

@iamstarkov

This comment has been minimized.

iamstarkov commented Nov 17, 2015

awesome work, look forward for future release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment