Skip to content
This repository

Release 1.6.0 discussion #268

Closed
wants to merge 1 commit into from

2 participants

Rocky Meza Tim Wood
Rocky Meza

Note: this pull request is not ready to be merged in.

I am opening up the version 1.6.0 release for discussion. In this pull request, I think we should talk about the features that need to be added or removed before we can cut a new version of moment. Here are some changes that I think should be in version 1.6.

Languages

To be removed

  • #228, old-style am/AM/pm/PM handling
  • #227, z zz timezone tokens
  • #216, moment.fn.native

New Features that have already been written

  • #253, Ender compatibility
  • #222, new-style am/AM/pm/PM handling
  • #266, Adding a getter for moment.lang()
  • #263, new parser
  • #254, support for S SS and SSS millisecond tokens
  • #236/#265, Durations
  • #267 - moment.clone() does not copy the _isUTC property
  • #261 - moment.diff() does not take into account utc mode
  • #213 - moment.unix() and moment.fn.unix()
  • #275 - moment.utc(string) parses ISO8601 as local time when timezone is missing

New features that have not been written

Things that should not go into this release

  • #266, per-instance language configuration -- 1.7 ???
  • #235, moment.fn.isValid -- 1.7 ???
  • #262, Two letter month name formatting tokens -- 1.7 ???
  • #283, Generic endOf and startOf to abstract sod/eod -- 1.7 ???
Tim Wood
Owner

We should also add moment.lang() as a getter as well. See #266.

This would be a good workaround before adding per instance lang configurations.

Tim Wood
Owner

FYI, I updated the list.

The new parser ended up taking much less time than I thought it would. It passes all the previous tests, plus the new 'YYYMMDD' tests. I think it's pretty stable, so it should be good to release.

I added lang as a getter, and moved the S/SS/SSS parsing issue up to the 'have been written' section.

I also added moment.fn.isValid and two letter month names to the 'not this release' section.

Tim Wood
Owner

I added these to the 'already written' section, and moved durations there as well.

  • #267 - moment.clone() does not copy the _isUTC property
  • #261 - moment.diff() does not take into account utc mode
  • #213 - moment.unix() and moment.fn.unix()
Tim Wood
Owner

I think this is ready to go, @rockymeza, is there anything I'm forgetting?

Rocky Meza
Rocky Meza

Nevermind, #284 seems to be a problem with incompatible versions of moment and and the kr.js file.

I think we're good to go @timrwood.

Tim Wood
Owner

Cool, all that is left is adding docs for durations and ender compatibility. I've created placeholders, so hopefully I can get it all written tonight. I'll ping you so you can double check them before I make the release.

Tim Wood
Owner

@rockymeza, I added docs for durations, please check it out over on https://github.com/timrwood/momentjs.com. Everything is just in the master branch there for now. (After 1.6.0 release, I think I'll switch that to git flow as well).

I also made you a collaborator on that site, so you should be able to push changes there as well.

After you look over the docs, I'll release 1.6.0.

Tim Wood
Owner

This is released!

Tim Wood timrwood closed this April 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Apr 08, 2012
Rocky Meza Opening release 1.6.0 for discussion/development d571f3e
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 1 deletion. Show diff stats Hide diff stats

  1. 2  moment.js
2  moment.js
@@ -26,7 +26,7 @@
26 26
             ['HH', /T\d\d/]
27 27
         ],
28 28
         timezoneParseRegex = /([\+\-]|\d\d)/gi,
29  
-        VERSION = "1.5.0",
  29
+        VERSION = "1.6.0",
30 30
         shortcuts = 'Month|Date|Hours|Minutes|Seconds|Milliseconds'.split('|');
31 31
 
32 32
     // Moment prototype object
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.