New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.6.0 discussion #268

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@rockymeza
Contributor

rockymeza commented Apr 8, 2012

Note: this pull request is not ready to be merged in.

I am opening up the version 1.6.0 release for discussion. In this pull request, I think we should talk about the features that need to be added or removed before we can cut a new version of moment. Here are some changes that I think should be in version 1.6.

Languages

To be removed

  • #228, old-style am/AM/pm/PM handling
  • #227, z zz timezone tokens
  • #216, moment.fn.native

New Features that have already been written

  • #253, Ender compatibility
  • #222, new-style am/AM/pm/PM handling
  • #266, Adding a getter for moment.lang()
  • #263, new parser
  • #254, support for S SS and SSS millisecond tokens
  • #236/#265, Durations
  • #267 - moment.clone() does not copy the _isUTC property
  • #261 - moment.diff() does not take into account utc mode
  • #213 - moment.unix() and moment.fn.unix()
  • #275 - moment.utc(string) parses ISO8601 as local time when timezone is missing

New features that have not been written

Things that should not go into this release

  • #266, per-instance language configuration -- 1.7 ???
  • #235, moment.fn.isValid -- 1.7 ???
  • #262, Two letter month name formatting tokens -- 1.7 ???
  • #283, Generic endOf and startOf to abstract sod/eod -- 1.7 ???
@timrwood

This comment has been minimized.

Member

timrwood commented Apr 8, 2012

We should also add moment.lang() as a getter as well. See #266.

This would be a good workaround before adding per instance lang configurations.

@timrwood

This comment has been minimized.

Member

timrwood commented Apr 11, 2012

FYI, I updated the list.

The new parser ended up taking much less time than I thought it would. It passes all the previous tests, plus the new 'YYYMMDD' tests. I think it's pretty stable, so it should be good to release.

I added lang as a getter, and moved the S/SS/SSS parsing issue up to the 'have been written' section.

I also added moment.fn.isValid and two letter month names to the 'not this release' section.

@timrwood

This comment has been minimized.

Member

timrwood commented Apr 24, 2012

I added these to the 'already written' section, and moved durations there as well.

  • #267 - moment.clone() does not copy the _isUTC property
  • #261 - moment.diff() does not take into account utc mode
  • #213 - moment.unix() and moment.fn.unix()
@timrwood

This comment has been minimized.

Member

timrwood commented Apr 25, 2012

I think this is ready to go, @rockymeza, is there anything I'm forgetting?

@rockymeza

This comment has been minimized.

Contributor

rockymeza commented Apr 25, 2012

Looks like a good solid release to me. What about that Korean bug? We
could probably stick that in too.
-rocky

On Tue, Apr 24, 2012 at 6:19 PM, Tim Wood <
reply@reply.github.com

wrote:

I think this is ready to go, @rockymeza, is there anything I'm forgetting?


Reply to this email directly or view it on GitHub:
#268 (comment)

@rockymeza

This comment has been minimized.

Contributor

rockymeza commented Apr 25, 2012

Nevermind, #284 seems to be a problem with incompatible versions of moment and and the kr.js file.

I think we're good to go @timrwood.

@timrwood

This comment has been minimized.

Member

timrwood commented Apr 25, 2012

Cool, all that is left is adding docs for durations and ender compatibility. I've created placeholders, so hopefully I can get it all written tonight. I'll ping you so you can double check them before I make the release.

@timrwood

This comment has been minimized.

Member

timrwood commented Apr 26, 2012

@rockymeza, I added docs for durations, please check it out over on https://github.com/timrwood/momentjs.com. Everything is just in the master branch there for now. (After 1.6.0 release, I think I'll switch that to git flow as well).

I also made you a collaborator on that site, so you should be able to push changes there as well.

After you look over the docs, I'll release 1.6.0.

@timrwood

This comment has been minimized.

Member

timrwood commented Apr 26, 2012

This is released!

@timrwood timrwood closed this Apr 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment