New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hmm and hmmss formatting tokens #2700

Merged
merged 2 commits into from Nov 9, 2015

Conversation

Projects
None yet
2 participants
@ichernev
Contributor

ichernev commented Oct 26, 2015

Now hmm and hmmss will be properly parsed. Note that hmm can parse 123 as 1 hour 23 minute and also 1234 which is 12 hour and 34 minutes

Fixes #2418

@mj1856

This comment has been minimized.

Member

mj1856 commented Oct 26, 2015

What about Hmm and Hmmss ?

@ichernev

This comment has been minimized.

Contributor

ichernev commented Nov 9, 2015

@mj1856 good catch.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Nov 9, 2015

Merged in a4e932b

@ichernev ichernev closed this Nov 9, 2015

@ichernev ichernev merged commit 90788a3 into moment:develop Nov 9, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ichernev added a commit that referenced this pull request Nov 9, 2015

Merge pull request #2700 from ichernev:hmm
Add hmm and hmmss formatting tokens

@mj1856 mj1856 added this to the 2.10.7 milestone Dec 15, 2015

@mj1856 mj1856 referenced this pull request Dec 15, 2015

Closed

Invalid date for 'Hmm' #2816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment