New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse ISO-8061 duration containing both day and week values #2818

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
3 participants
@JohnAnthony
Contributor

JohnAnthony commented Dec 16, 2015

This should resolve issue #2797

More generally it looks like it was previously not possible to combine week values with anything else; when weeks were specified they had to be the ONLY value given.

@mj1856

This comment has been minimized.

Member

mj1856 commented Jan 16, 2016

LGTM. Thanks! Staging for next release.

@mj1856

This comment has been minimized.

Member

mj1856 commented Jan 16, 2016

Actually, @JohnAnthony - could you please rebase to collapse this into one commit? Thanks.

@JohnAnthony

This comment has been minimized.

Contributor

JohnAnthony commented Jan 16, 2016

Rebased. Glad to be able to contribute.

@mj1856

This comment has been minimized.

Member

mj1856 commented Jan 19, 2016

Looks good. We'll merge in the next release. Thanks!

@ichernev

This comment has been minimized.

Contributor

ichernev commented Mar 6, 2016

Merged in cfc7698

@ichernev ichernev closed this Mar 6, 2016

ichernev added a commit that referenced this pull request Mar 6, 2016

Merge pull request #2818 from JohnAnthony:parse-duration-day-and-week
Parse ISO-8061 duration containing both day and week values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment