New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typeof checks for undefined for global variables #2865

Closed
wants to merge 2 commits into
base: develop
from

Conversation

Projects
None yet
2 participants
@ichernev
Contributor

ichernev commented Jan 5, 2016

Fixes #2862

broken in #2773.

@mj1856 mj1856 added the High Priority label Jan 6, 2016

@mj1856 mj1856 added this to the 2.11.1 milestone Jan 6, 2016

@mj1856

This comment has been minimized.

Member

mj1856 commented Jan 6, 2016

LGTM, and much appreciated. Thanks!

@ichernev

This comment has been minimized.

Contributor

ichernev commented Jan 9, 2016

Merged in 5925ade

@ichernev ichernev closed this Jan 9, 2016

ichernev added a commit that referenced this pull request Jan 9, 2016

Merge pull request #2865 from ichernev:fix-undefined-checks
Use typeof checks for undefined for global variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment