New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix months parsing for stranger locales #2869

Closed
wants to merge 3 commits into
base: develop
from

Conversation

Projects
None yet
3 participants
@ichernev
Contributor

ichernev commented Jan 6, 2016

This fixes #2841

TODO:

  • add weekdays in the mix
  • test with months ending in dot and enable it there too
  • sort regex parts by reverse length
  • add tests specific to this feature
  • fix polish monthsParse hack

@ichernev ichernev added this to the 2.11.1 milestone Jan 9, 2016

@ichernev

This comment has been minimized.

Contributor

ichernev commented Jan 9, 2016

This got out of hand. I'll merge it because it does fix gd locale without breaking everything else. But a proper fix is still to come.

@zakhenry

This comment has been minimized.

zakhenry commented Jan 9, 2016

@ichernev will this merge allow 2.11.1 to be tagged?

@ichernev

This comment has been minimized.

Contributor

ichernev commented Jan 9, 2016

@xiphiaz I'll merge, tag and everything very soon.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Jan 9, 2016

Merged in cd03dae

@ichernev ichernev closed this Jan 9, 2016

ichernev added a commit that referenced this pull request Jan 9, 2016

Merge pull request #2869 from ichernev:per-locale-month-regex
Fix months parsing for stranger locales
@mj1856

This comment has been minimized.

Member

mj1856 commented Jan 11, 2016

@ichernev - Are all 5 of the checkboxes at the top of this completed, or just the one?

@ichernev

This comment has been minimized.

Contributor

ichernev commented Mar 31, 2016

@mj1856 only one. I completely forgot about this one. I'm re-doing #2782 using this code (completing the TODO list :)).

@ichernev ichernev referenced this pull request Mar 31, 2016

Closed

Fix parsing for months/weekdays with weird characters #3078

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment